Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamodb): stream resource policy for Table(v1) #31515

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LeeroyHannigan
Copy link
Contributor

Issue # (if applicable)

Closes #31229.

Reason for this change

Users were unable to add a resource policy to a DynamoDB stream

Description of changes

Implemented resource policies for Table (V1) streams

Description of how you validated changes

Integ testing added

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Sep 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 21, 2024 08:21
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@LeeroyHannigan LeeroyHannigan changed the title feat(dynamodb): Stream resource policy for Table(v1) feat(dynamodb): stream resource policy for Table(v1) Sep 21, 2024
@LeeroyHannigan
Copy link
Contributor Author

LeeroyHannigan commented Sep 21, 2024

Clarification Request: README for TableV1 Updated packages/aws-cdk-lib/aws-dynamodb/TABLE_V1_API.md

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Sep 21, 2024
@LeeroyHannigan LeeroyHannigan changed the title feat(dynamodb): stream resource policy for Table(v1) fix(dynamodb): stream resource policy for Table(v1) Sep 21, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 21, 2024 09:59

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a5c6167
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-dynamodb: Unable to set resource policy on DDB streams
2 participants